> On Dec. 14, 2015, 8:06 p.m., Timothy Chen wrote: > > src/docker/docker.cpp, line 603 > > <https://reviews.apache.org/r/41294/diff/2/?file=1164051#file1164051line603> > > > > Just a general question, what is the reasoning behind allowing the > > logger to modify the path and argv of the original subprocess?
A couple of reasons: * We need the thing-performing-the-loggging to be run as a process separate from the logging module. `Subprocess::IO::PIPE` will not be sufficient since we can't read from the pipe when the agent process falls over. * The logging process might need to do something more complicated than redirecting stdout/stderr to a FD. * Some logging daemons (wrappers) are launched by prepending the to the argc/argv array. i.e. `logger-daemon <logger options> <original "path"> <original argv>` - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110395 ----------------------------------------------------------- On Dec. 14, 2015, 6:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41294/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:14 p.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, and Artem > Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > The `DockerContainerizer` creates and initializes its own `ContainerLogger` > and passes it into the `Docker` wrapper. > > The `ContainerLogger` is used before launching executors, in two two call > sites depending on whether the agent is running in a container or not. > > > Diffs > ----- > > src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb > src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a > src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/41294/diff/ > > > Testing > ------- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
