> On Dec. 14, 2015, 7:51 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 139 > > <https://reviews.apache.org/r/41294/diff/2/?file=1164053#file1164053line139> > > > > Why not let the create also initialize?
This was an artifact of one of the approaches (now discarded) I tried, regarding where to insert the module. I agree that we can `init` in `create`. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41294/#review110388 ----------------------------------------------------------- On Dec. 14, 2015, 6:14 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41294/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 6:14 p.m.) > > > Review request for mesos, Benjamin Hindman, haosdent huang, and Artem > Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > The `DockerContainerizer` creates and initializes its own `ContainerLogger` > and passes it into the `Docker` wrapper. > > The `ContainerLogger` is used before launching executors, in two two call > sites depending on whether the agent is running in a container or not. > > > Diffs > ----- > > src/docker/docker.hpp 33d6fb3e82ff7328ad093648a45546a18ec7b8cb > src/docker/docker.cpp 5dc4667d93b143b54841d85606affe3e4926757a > src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/41294/diff/ > > > Testing > ------- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
