> On Dec. 14, 2015, 7:28 p.m., Joseph Wu wrote: > > FYI, I'm making conflicting changes as part of work on a "logging module". > > I published an incomplete patch so you can see the conflicts: > > https://reviews.apache.org/r/41294/ > > haosdent huang wrote: > Thank you very much. Should I discard my patch first? Basically I just > want to unify Containerizer interface, then put it forward become a module. > > Joseph Wu wrote: > You probably don't need to discard. I just wanted to let you know about > a future rebase conflict :)
Got it. I would rebase after your patch submitted. - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41299/#review110290 ----------------------------------------------------------- On Dec. 13, 2015, 5:35 a.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41299/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2015, 5:35 a.m.) > > > Review request for mesos, Ben Mahler and Timothy Chen. > > > Bugs: MESOS-4141 > https://issues.apache.org/jira/browse/MESOS-4141 > > > Repository: mesos > > > Description > ------- > > Allow DockerContainerizer log to console. > > > Diffs > ----- > > src/slave/containerizer/containerizer.cpp > dcdf98fea4ca6f96658886db5d09c99f3bff501d > src/slave/containerizer/docker.hpp 35712f599395b5f5fbc311a37c6e29b33bac0c8e > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > src/tests/containerizer/docker_containerizer_tests.cpp > 3f199e622dd337cdbf32d4368f4ead424c39823c > src/tests/health_check_tests.cpp 0fbccc373204d3b9431c614bdd6d046cc07e4566 > src/tests/hook_tests.cpp e034534295fe6ddd280e25f1d9ee5182cddae187 > src/tests/mesos.hpp 2429ac5cbcd9c1a3949c11de94b542108a3c13d8 > src/tests/mesos.cpp a501f04dfbf9c93c2196e83b512519e925a67c97 > > Diff: https://reviews.apache.org/r/41299/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
