> On Dec. 14, 2015, 7:54 p.m., Timothy Chen wrote:
> > src/docker/executor.hpp, line 89
> > <https://reviews.apache.org/r/41369/diff/1/?file=1164058#file1164058line89>
> >
> >     Why default to an empty string?

I forgot about module parameters when adding this flag.  The `options` have now 
been removed.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41369/#review110389
-----------------------------------------------------------


On Dec. 15, 2015, 12:41 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41369/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 12:41 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4137
>     https://issues.apache.org/jira/browse/MESOS-4137
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adds `ContainerLogger` flags, creation, and initialization to the Mesos 
> Docker executor.  This `ContainerLogger` instance runs in the executor itself.
> 
> 
> Diffs
> -----
> 
>   src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 
>   src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 
>   src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e 
> 
> Diff: https://reviews.apache.org/r/41369/diff/
> 
> 
> Testing
> -------
> 
> Tests will be modified and run later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to