----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41369/#review111431 -----------------------------------------------------------
This looks nicely mechanical given https://reviews.apache.org/r/41294 but please see the comment there! src/docker/executor.hpp (lines 69 - 70) <https://reviews.apache.org/r/41369/#comment171606> What do you mean by "as in the sandbox"? - Benjamin Hindman On Dec. 15, 2015, 8:41 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41369/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 8:41 p.m.) > > > Review request for mesos, Benjamin Hindman and Artem Harutyunyan. > > > Bugs: MESOS-4137 > https://issues.apache.org/jira/browse/MESOS-4137 > > > Repository: mesos > > > Description > ------- > > Adds `ContainerLogger` flags, creation, and initialization to the Mesos > Docker executor. This `ContainerLogger` instance runs in the executor itself. > > > Diffs > ----- > > src/docker/executor.hpp abbc419533ab40312e917931a2fc2ce78b38da41 > src/docker/executor.cpp 4042cec0acbe03d937ea3c53ffde745cbba552d2 > src/slave/containerizer/docker.cpp 2d2dd4e0df36207c5f3cbb4fe2c50df51c0f3e9e > > Diff: https://reviews.apache.org/r/41369/diff/ > > > Testing > ------- > > Tests will be modified and run later in the review chain. > > > Thanks, > > Joseph Wu > >
