----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/ -----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, Joseph Wu, and Niklas Nielsen. Bugs: MESOS-3909 https://issues.apache.org/jira/browse/MESOS-3909 Repository: mesos Description ------- The pkg-config file needs to explicitly set the -I path, and also set and preprocessor definitions that Mesos assumes will be set for picojson.h. Diffs ----- mesos.pc.in bc4f7e778dd8e5e2bd5e8f4181d62934ac423135 Diff: https://reviews.apache.org/r/41425/diff/ Testing ------- Check various pkg-config invocations and make sure they are sane: $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --libs mesos -L/opt/mesos/lib -lmesos $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags mesos -DPICOJSON_USE_INT64 -D__STDC_FORMAT_MACROS -I/opt/mesos/include $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags-only-I mesos -I/opt/mesos/include Thanks, James Peach