> On Dec. 23, 2015, 9:15 p.m., Alex Clemmer wrote: > > Just as a short note here, `pkg-config` doesn't work well with the rest of > > the Windows tool chain, so it's worth wondering what our distribution story > > should be there. > > > > If the consumer is using CMake, then this information is trivially and > > seamlessly communicated to whoever is linking to it. If this is not true, > > we will probably have to support at least one other distribution channel > > (such as NuGet), and possibly many. > > > > Can we add `alexnaparu` and `dpravat` to the review and get their feedback > > as well? > > Alex Clemmer wrote: > The JIRA issue is here: https://issues.apache.org/jira/browse/MESOS-4245
I added the extra people. Let's not expand the scope to CMake in this review. I have a very simple build that consumes the existing ``pkg-config`` support. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41425/#review111806 ----------------------------------------------------------- On Dec. 22, 2015, 8:45 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41425/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 8:45 p.m.) > > > Review request for mesos, Benjamin Hindman, Ben Mahler, Alex Clemmer, Joris > Van Remoortere, Joseph Wu, and Niklas Nielsen. > > > Bugs: MESOS-3909 > https://issues.apache.org/jira/browse/MESOS-3909 > > > Repository: mesos > > > Description > ------- > > The pkg-config file needs to explicitly set the -I path, and also > set and preprocessor definitions that Mesos assumes will be set for > picojson.h. > > > Diffs > ----- > > mesos.pc.in bc4f7e778dd8e5e2bd5e8f4181d62934ac423135 > > Diff: https://reviews.apache.org/r/41425/diff/ > > > Testing > ------- > > Check various pkg-config invocations and make sure they are sane: > > $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --libs mesos > -L/opt/mesos/lib -lmesos > $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags mesos > -DPICOJSON_USE_INT64 -D__STDC_FORMAT_MACROS -I/opt/mesos/include > $ PKG_CONFIG_PATH=/opt/mesos/lib/pkgconfig pkg-config --cflags-only-I > mesos > -I/opt/mesos/include > > > Thanks, > > James Peach > >
