----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41438/#review110932 -----------------------------------------------------------
docs/fetcher.md (line 224) <https://reviews.apache.org/r/41438/#comment170934> s/a/an How about this title? "HTTP and SOCKS proxy settings" docs/fetcher.md (lines 225 - 226) <https://reviews.apache.org/r/41438/#comment170935> s/it's/it is docs/fetcher.md (line 229) <https://reviews.apache.org/r/41438/#comment170939> Since multiple protocols may be addressed, would plural read better here? "when certain environment variables are set." (Otherwise, an "a" is missing before "certain".) docs/fetcher.md (line 231) <https://reviews.apache.org/r/41438/#comment170941> s/The/The respective This may make it even more clear that this is a variable per scheme docs/fetcher.md (line 232) <https://reviews.apache.org/r/41438/#comment170942> s/uri/URI BTW: You can end the sentence after this word and start a new one. docs/fetcher.md (line 239) <https://reviews.apache.org/r/41438/#comment170946> We should point out that FTP/FTPS also go over HTTP/HTTPS proxies. Even though in general this constrains the available FTP protocol operations, everything the fetcher uses is supported. docs/fetcher.md (line 241) <https://reviews.apache.org/r/41438/#comment170948> Suggestion: "Your proxy settings can be placed in `...`. Here is an example:" docs/fetcher.md (line 244) <https://reviews.apache.org/r/41438/#comment170950> Did you not have to write "export" in front? I know of a case where nothing worked unless you did. docs/fetcher.md (line 248) <https://reviews.apache.org/r/41438/#comment170944> Suggestion (less uncertain than "would" and less colloquial than "get"): The fetcher will pick up these environment variable settings since the utility program mesos-fetcher which it employs is a child of mesos-slave. - Bernd Mathiske On Dec. 16, 2015, 12:27 a.m., Shuai Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41438/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 12:27 a.m.) > > > Review request for mesos and Bernd Mathiske. > > > Bugs: MESOS-4130 > https://issues.apache.org/jira/browse/MESOS-4130 > > > Repository: mesos > > > Description > ------- > > Added documentation on using network proxy for mesos fetcher > > > Diffs > ----- > > docs/fetcher.md ec7372293491ed9ee4e20dda3c2def72a77a3f84 > > Diff: https://reviews.apache.org/r/41438/diff/ > > > Testing > ------- > > - Set `https_proxy=http://localhost:3128` (a local squid server) in > `/etc/default/mesos-slave`, restart mesos-slave, launch a new marathon task > with a `https://` uri, and through the following sysdig command I can see > there is data exchanging between mesos-fetcher process and port 3128. > > ``` > sudo sysdig -A -c echo_fds proc.name=mesos-fetcher and fd.port=3128 > ``` > > - Stop the local squid server, try to restart the marathon task, the task > would fail repeatly, from slave logs there are error messages that fetcher > failed to fetch the uri. > ``` > Dec 16 15:16:35 lin-E400 mesos-slave[24247]: E1216 15:16:35.678032 24283 > slave.cpp:3342] Container '45c14132-c56a-4cff-a6b5-f57ba2670643' for executor > 'testapp_web.f0ef72d2-a3c4-11e5-af60-56847afe9799' of framework > 'b52179fd-8968-4 > bf8-baf0-dddc8a38c903-0000' failed to start: Failed to fetch all URIs for > container '45c14132-c56a-4cff-a6b5-f57ba2670643' with exit status: 2 > ``` > > - Restart the squid server, the task would start without a problem. > > > Thanks, > > Shuai Lin > >
