----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111086 -----------------------------------------------------------
LGTM.. Just some nits around: - using `const` for test strings. - reducing jaggedness for some blocks. Also, a query regarding just accepting `true/false` as `force` field values. src/master/quota_handler.cpp (line 250) <https://reviews.apache.org/r/41514/#comment171067> nit: use backticks (`force`) s/flag/field src/master/quota_handler.cpp (line 274) <https://reviews.apache.org/r/41514/#comment171066> hmm, why don't we do a `using google::protobuf::RepeatedPtrField` and get rid of all this jaggedness ? src/master/quota_handler.cpp (line 313) <https://reviews.apache.org/r/41514/#comment171064> I like the less jagged version more here. It's also more consistent with other similar strings in the function. What do you think ? src/master/quota_handler.cpp (line 328) <https://reviews.apache.org/r/41514/#comment171062> hmmm .. Should we return a `BadRequest` for all other non-allowed values of `force` other then `true` or `false` ? src/tests/master_quota_tests.cpp (line 116) <https://reviews.apache.org/r/41514/#comment171059> nit: `const string` src/tests/master_quota_tests.cpp (line 122) <https://reviews.apache.org/r/41514/#comment171060> nit: `const string` src/tests/master_quota_tests.cpp (line 199) <https://reviews.apache.org/r/41514/#comment171061> Not related to this review : Why don't we make all these `badRequest` expected strings `const` ? - Anand Mazumdar On Dec. 17, 2015, 2:52 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41514/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 2:52 p.m.) > > > Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and > Joris Van Remoortere. > > > Bugs: MESOS-3960 > https://issues.apache.org/jira/browse/MESOS-3960 > > > Repository: mesos > > > Description > ------- > > POST request to "/quota" requires a single JSON object as opposed to > key-value pairs encoded in a string. > > > Diffs > ----- > > src/master/quota_handler.cpp 11167879b2480d9c8dd6398ca39c479089ec2272 > src/tests/master_quota_tests.cpp 0473869783a714766ed26fff61d7f8c56342df74 > > Diff: https://reviews.apache.org/r/41514/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
