> On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/master/quota_handler.cpp, line 299 > > <https://reviews.apache.org/r/41514/diff/1/?file=1168675#file1168675line299> > > > > hmm, why don't we do a `using google::protobuf::RepeatedPtrField` and > > get rid of all this jaggedness ? > > Alexander Rukletsov wrote: > Yeah, and also `#include` it properly : )
Fixed in https://reviews.apache.org/r/41603/ > On Dec. 18, 2015, 12:04 a.m., Anand Mazumdar wrote: > > src/tests/master_quota_tests.cpp, line 199 > > <https://reviews.apache.org/r/41514/diff/1/?file=1168676#file1168676line199> > > > > Not related to this review : Why don't we make all these `badRequest` > > expected strings `const` ? > > Alexander Rukletsov wrote: > Yeah, let's fix it. Thanks! Cleaned up in https://reviews.apache.org/r/41603/ - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41514/#review111086 ----------------------------------------------------------- On Dec. 21, 2015, 1:27 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41514/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 1:27 p.m.) > > > Review request for mesos, Anand Mazumdar, Bernd Mathiske, Joerg Schad, and > Joris Van Remoortere. > > > Bugs: MESOS-3960 > https://issues.apache.org/jira/browse/MESOS-3960 > > > Repository: mesos > > > Description > ------- > > POST request to "/quota" requires a single JSON object as opposed to > key-value pairs encoded in a string. > > > Diffs > ----- > > src/master/quota_handler.cpp 0217149a865ede751b3a03fe40b2d91b487b7b10 > src/tests/master_quota_tests.cpp 89130ce9b09afe7c6dd332c8b5278abe0d2674f1 > src/tests/role_tests.cpp 2c5f68ccaac7e9a37345e2f331d1bc35cae77736 > > Diff: https://reviews.apache.org/r/41514/diff/ > > > Testing > ------- > > make check on Mac OS 10.10.4 > > > Thanks, > > Alexander Rukletsov > >
