-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40995/#review111089
-----------------------------------------------------------

Ship it!


Looks great! Just a couple of test macro suggestions (applicable in multiple 
tests), and then I'll commit it.


src/tests/role_tests.cpp (lines 79 - 83)
<https://reviews.apache.org/r/40995/#comment171073>

    `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, "Content-Type", 
response);` all fits on one line, and does the AWAITY_READY(response) as well 
as the header EQ check.
    You'll have to `include <mesos/http.hpp>` to get `APPLICATION_JSON`.



src/tests/role_tests.cpp (line 105)
<https://reviews.apache.org/r/40995/#comment171074>

    Not sure why you're using EXPECT_SOME_EQ rather than EXPECT_EQ, since 
you're already doing ASSERT_SOME on `parse` and `expected`.


- Adam B


On Dec. 16, 2015, 1:05 p.m., Neil Conway wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40995/
> -----------------------------------------------------------
> 
> (Updated Dec. 16, 2015, 1:05 p.m.)
> 
> 
> Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and 
> Yongqiao Wang.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added test cases for role behavior.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 8f6b98b5b0ddbfe6b97346704cb96937e0eca02e 
>   src/tests/reservation_tests.cpp f429472e6b93a5d6d8fe6a5f7d5b94fc331f7295 
>   src/tests/role_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/40995/diff/
> 
> 
> Testing
> -------
> 
> make check.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Reply via email to