> On Dec. 17, 2015, 4:57 p.m., Adam B wrote: > > src/tests/role_tests.cpp, lines 79-83 > > <https://reviews.apache.org/r/40995/diff/9/?file=1167052#file1167052line79> > > > > `AWAIT_EXPECT_RESPONSE_HEADER_EQ(APPLICATION_JSON, "Content-Type", > > response);` all fits on one line, and does the AWAITY_READY(response) as > > well as the header EQ check. > > You'll have to `include <mesos/http.hpp>` to get `APPLICATION_JSON`. > > Neil Conway wrote: > Fixed. To avoid the need to resolve some merge conflicts on rebase, I > actually made this fix in https://reviews.apache.org/r/41225/ -- let me know > if you'd rather I do the rebase + cleanup.
That's fine. - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40995/#review111089 ----------------------------------------------------------- On Dec. 17, 2015, 5:54 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40995/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2015, 5:54 p.m.) > > > Review request for mesos, Adam B, Alexander Rukletsov, Greg Mann, and > Yongqiao Wang. > > > Repository: mesos > > > Description > ------- > > Added test cases for role behavior. > > > Diffs > ----- > > src/Makefile.am e6d48dc16135b5d147d036e851422686eff7d5ef > src/tests/reservation_tests.cpp f429472e6b93a5d6d8fe6a5f7d5b94fc331f7295 > src/tests/role_tests.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/40995/diff/ > > > Testing > ------- > > make check. > > > Thanks, > > Neil Conway > >
