----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41408/#review111122 -----------------------------------------------------------
Looks good, but please also update the CHANGELOG and configuration.md docs/upgrades.md (line 11) <https://reviews.apache.org/r/41408/#comment171114> Let's call out this JIRA(s) in the API changes section in the 0.27 CHANGELOG as well. docs/upgrades.md (lines 12 - 13) <https://reviews.apache.org/r/41408/#comment171117> "must be specified" - if you want to use roles. You can leave it out, but everything goes to "*" docs/upgrades.md (line 18) <https://reviews.apache.org/r/41408/#comment171111> Link to a JIRA, diff, or other doc that explains the API change in more detail. src/master/flags.cpp (lines 186 - 188) <https://reviews.apache.org/r/41408/#comment171109> Don't forget to update configuration.md to match your change to the flags. - Adam B On Dec. 15, 2015, 12:59 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41408/ > ----------------------------------------------------------- > > (Updated Dec. 15, 2015, 12:59 p.m.) > > > Review request for mesos, Adam B and Yongqiao Wang. > > > Bugs: MESOS-4085 > https://issues.apache.org/jira/browse/MESOS-4085 > > > Repository: mesos > > > Description > ------- > > Updated documentation for implicit roles. > > > Diffs > ----- > > docs/attributes-resources.md 3c5f2776d44a050ee3ac9967dd0ba0253b9c4558 > docs/configuration.md c75f56ce849f6960b3b6246bfa6949156a82eabb > docs/roles.md 459d70717f4a0bdd921bb18b6ddc2505b6fc596e > docs/upgrades.md 7c1f1814680078380ca33bbc27421675ffe61d60 > src/master/flags.cpp f9223edb33483cb5619e7dd75221f735306462c6 > > Diff: https://reviews.apache.org/r/41408/diff/ > > > Testing > ------- > > > Thanks, > > Neil Conway > >
