----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40255/#review111163 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp (lines 887 - 890) <https://reviews.apache.org/r/40255/#comment171190> It looks like this rule is not used in this test. Could you please explain why you have it here? src/tests/persistent_volume_tests.cpp (line 908) <https://reviews.apache.org/r/40255/#comment171188> I would merge this comment with the one on L903, this way you can avoid inserting a missing blank line between L907 and L908 : ). Same below. src/tests/persistent_volume_tests.cpp (lines 978 - 981) <https://reviews.apache.org/r/40255/#comment171189> I think you decided to rewrite this block a bit. Same for other EXPECT blobs with comments. src/tests/persistent_volume_tests.cpp (lines 1134 - 1135) <https://reviews.apache.org/r/40255/#comment171192> Instead of "magic constants", which may lead to flaky tests, does it make sense to `suppressOffers` and then `reviveOffers`? Same for the next test. src/tests/persistent_volume_tests.cpp (lines 1185 - 1187) <https://reviews.apache.org/r/40255/#comment171193> Why do you think framework1 will be offered resources? - Alexander Rukletsov On Dec. 18, 2015, 10:10 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40255/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2015, 10:10 a.m.) > > > Review request for mesos, Jie Yu, Michael Park, and Neil Conway. > > > Bugs: MESOS-3065 > https://issues.apache.org/jira/browse/MESOS-3065 > > > Repository: mesos > > > Description > ------- > > Added framework authorization for persistent volumes. > > > Diffs > ----- > > src/master/master.cpp 470b542729b01f41fc6a2e601a7a6c3d0c5353d5 > src/tests/persistent_volume_tests.cpp > 01b3c13751a5558d5f06edb8f650c8644dc54486 > > Diff: https://reviews.apache.org/r/40255/diff/ > > > Testing > ------- > > This is the fifth in a chain of 7 patches. New tests were added to > `persistent_volume_tests.cpp` in order to test a framework attempting both > successful and failed authorizations for `CREATE` and `DESTROY` offer > operations. `make check` was used to test after all patches were applied. > > > Thanks, > > Greg Mann > >