> On Dec. 18, 2015, 7:59 p.m., Jie Yu wrote:
> >

Thanks for the reviews, Jie!


> On Dec. 18, 2015, 7:59 p.m., Jie Yu wrote:
> > src/tests/persistent_volume_tests.cpp, line 751
> > <https://reviews.apache.org/r/40255/diff/7/?file=1170740#file1170740line751>
> >
> >     If you pause the clock, looks like this is not needed?

Yes, correct, good call. I posted another patch that defines a 
`DEFAULT_ALLOCATION_INTERVAL` and exposes it in `master/constants.hpp` so that 
we can make use of it: https://reviews.apache.org/r/41573/ This will be useful 
as we migrate more tests to control the clock explicitly.


- Greg


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40255/#review111233
-----------------------------------------------------------


On Dec. 18, 2015, 11:12 p.m., Greg Mann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40255/
> -----------------------------------------------------------
> 
> (Updated Dec. 18, 2015, 11:12 p.m.)
> 
> 
> Review request for mesos, Jie Yu, Michael Park, and Neil Conway.
> 
> 
> Bugs: MESOS-3065
>     https://issues.apache.org/jira/browse/MESOS-3065
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added framework authorization for persistent volumes.
> 
> 
> Diffs
> -----
> 
>   src/master/master.cpp 470b542729b01f41fc6a2e601a7a6c3d0c5353d5 
>   src/tests/persistent_volume_tests.cpp 
> 01b3c13751a5558d5f06edb8f650c8644dc54486 
> 
> Diff: https://reviews.apache.org/r/40255/diff/
> 
> 
> Testing
> -------
> 
> This is the fifth in a chain of 7 patches. New tests were added to 
> `persistent_volume_tests.cpp` in order to test a framework attempting both 
> successful and failed authorizations for `CREATE` and `DESTROY` offer 
> operations. `make check` was used to test after all patches were applied.
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Reply via email to