-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41167/#review111425
-----------------------------------------------------------


I understand we'll be making some cleanups here, but otherwise this looks good 
to me. I'll give it one final pass after the cleanups.


src/slave/containerizer/mesos/containerizer.hpp (line 58)
<https://reviews.apache.org/r/41167/#comment171601>

    I'd like to s/containerLogger/logger/ throughout the reviews. I don't see 
the prefix helpful here.



src/slave/containerizer/mesos/containerizer.cpp (line 820)
<https://reviews.apache.org/r/41167/#comment171602>

    const &


- Benjamin Hindman


On Dec. 15, 2015, 8:40 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41167/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
>     https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes the `MesosContainerizer` to create and initialize the 
> `ContainerLogger`.  
> 
> The `MesosContainerizer` modifies the arguments to `launcher->fork()` (in 
> `::_launch`) by calling the `ContainerLogger` beforehand.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> ab87cbcc843b471c7931aa38a590896f97be9865 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 8242190dffa4d011ee2728a9f0a04d3857767b69 
> 
> Diff: https://reviews.apache.org/r/41167/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> This is tested later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to