> On Dec. 14, 2015, 9:21 p.m., Jie Yu wrote:
> > src/slave/main.cpp, lines 227-245
> > <https://reviews.apache.org/r/41167/diff/2/?file=1161083#file1161083line227>
> >
> >     I am wondering why logger has to be injected, instead of being owned by 
> > containerizer? Let containerizer owning the logger can simplify the 
> > implementation (especially the tests) a lot.
> >     
> >     Also, logically speaking, logger should be part of the containerizer, 
> > not the agent.
> 
> Joseph Wu wrote:
>     Migrated the `ContainerLogger` into the `MesosContainerizer`.  I also 
> tweaked some comments in the interface (way back at the beginning of this 
> review chain).

To be clear, we definitely still want to _inject_ it (which the current code I 
just reviewed does), so that we can easily test with a `MockContainerLogger`, 
but we can just inject the logger and let the containerizer own it rather than 
dealing with cleanup outside.


- Benjamin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41167/#review110308
-----------------------------------------------------------


On Dec. 15, 2015, 8:40 p.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41167/
> -----------------------------------------------------------
> 
> (Updated Dec. 15, 2015, 8:40 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
> 
> 
> Bugs: MESOS-4088
>     https://issues.apache.org/jira/browse/MESOS-4088
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Changes the `MesosContainerizer` to create and initialize the 
> `ContainerLogger`.  
> 
> The `MesosContainerizer` modifies the arguments to `launcher->fork()` (in 
> `::_launch`) by calling the `ContainerLogger` beforehand.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/containerizer.hpp 
> ab87cbcc843b471c7931aa38a590896f97be9865 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 8242190dffa4d011ee2728a9f0a04d3857767b69 
> 
> Diff: https://reviews.apache.org/r/41167/diff/
> 
> 
> Testing
> -------
> 
> make
> 
> This is tested later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to