-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41002/#review111436
-----------------------------------------------------------



include/mesos/slave/container_logger.hpp (lines 85 - 93)
<https://reviews.apache.org/r/41002/#comment171609>

    I'm a little confused. Who executes this? The comment makes it read like 
there is some particular code that executes this, which makes me wonder why it 
needs to be a static function on `ContainerLogger`?
    
    And why don't we want `SubprocessInfo::out/err` to use pipes? I thought 
that was the whole point?
    
    Finally, killing the agent seems a little bit harsh. Couldn't the container 
just get killed?


- Benjamin Hindman


On Dec. 21, 2015, 12:39 a.m., Joseph Wu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41002/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2015, 12:39 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, Artem Harutyunyan, 
> and Thomas Rampelberg.
> 
> 
> Bugs: MESOS-4087
>     https://issues.apache.org/jira/browse/MESOS-4087
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> The container logger is an agent module whose job is to take an executor or 
> task's stdout/stderr, and pipe it to some sink.
> 
> Existing executor and task stdout/stderr are piped into files ("stdout" and 
> "stderr") located in the executor's sandbox directory.
> This module aims to encompass this default behavior as well as allow more 
> sophisticated logging solutions.
> 
> 
> Diffs
> -----
> 
>   include/mesos/slave/container_logger.hpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41002/diff/
> 
> 
> Testing
> -------
> 
> This is added to the Makefile later in the review chain.
> 
> 
> Thanks,
> 
> Joseph Wu
> 
>

Reply via email to