> On Dec. 20, 2015, 6:21 p.m., Benjamin Hindman wrote: > > include/mesos/slave/container_logger.hpp, lines 85-93 > > <https://reviews.apache.org/r/41002/diff/10/?file=1173564#file1173564line85> > > > > I'm a little confused. Who executes this? The comment makes it read > > like there is some particular code that executes this, which makes me > > wonder why it needs to be a static function on `ContainerLogger`? > > > > And why don't we want `SubprocessInfo::out/err` to use pipes? I thought > > that was the whole point? > > > > Finally, killing the agent seems a little bit harsh. Couldn't the > > container just get killed? > > Joseph Wu wrote: > This is meant to enforce the `NOTE` in `SubprocessInfo` about how the > module may not specify `Subprocess::IO::PIPE()` as part of the return value. > > I talked with Joris about either making this a compile-time or run-time > check, and we decided that a compile-time check would be somewhat distracting > compared to a `validate` function like this. (We would need to add a new > class that provides just `Subprocess::FD` and `Subprocess::PATH`.) > > This function will exit on failure because it indicates that the chosen > `ContainerLogger` breaks that assumption.
Changed to a compile-time restriction, as discussed. - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41002/#review111436 ----------------------------------------------------------- On Dec. 21, 2015, 4:49 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41002/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2015, 4:49 p.m.) > > > Review request for mesos, Benjamin Hindman, Cody Maloney, Artem Harutyunyan, > and Thomas Rampelberg. > > > Bugs: MESOS-4087 > https://issues.apache.org/jira/browse/MESOS-4087 > > > Repository: mesos > > > Description > ------- > > The container logger is an agent module whose job is to take an executor or > task's stdout/stderr, and pipe it to some sink. > > Existing executor and task stdout/stderr are piped into files ("stdout" and > "stderr") located in the executor's sandbox directory. > This module aims to encompass this default behavior as well as allow more > sophisticated logging solutions. > > > Diffs > ----- > > include/mesos/slave/container_logger.hpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41002/diff/ > > > Testing > ------- > > This is added to the Makefile later in the review chain. > > > Thanks, > > Joseph Wu > >
