----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41472/#review111483 -----------------------------------------------------------
src/master/http.cpp (line 1001) <https://reviews.apache.org/r/41472/#comment171699> We actually don't need this `if` statement. Although the `role` field is marked `optional`, we "fill it in" with the default value of `"*"` if unspecified by simply calling `role()`. `roleWhitelist` always has `"*"`. https://github.com/apache/mesos/blob/master/src/master/master.cpp#L564-L565 - Michael Park On Dec. 16, 2015, 10:48 p.m., Neil Conway wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41472/ > ----------------------------------------------------------- > > (Updated Dec. 16, 2015, 10:48 p.m.) > > > Review request for mesos, Adam B and Michael Park. > > > Bugs: MESOS-4143 > https://issues.apache.org/jira/browse/MESOS-4143 > > > Repository: mesos > > > Description > ------- > > Also added a test that dynamic reservations via the "/reserve" endpoint are > allowed when using implicit roles. > > > Diffs > ----- > > src/master/http.cpp 8dfd67f7d51b8395953d6beb77b2d71bc538eacd > src/tests/reservation_endpoints_tests.cpp > b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 > > Diff: https://reviews.apache.org/r/41472/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Neil Conway > >