----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40944/#review111726 -----------------------------------------------------------
Ship it! Ship It! src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 117) <https://reviews.apache.org/r/40944/#comment171957> We should elaborate more here: "Failed to parse v1Compatbility json: "...... src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 125) <https://reviews.apache.org/r/40944/#comment171956> I would make the error message more exact (Parsing v1Compatibility protobuf failed:....). src/slave/containerizer/mesos/provisioner/docker/spec.cpp (line 129) <https://reviews.apache.org/r/40944/#comment171958> We never expect this to happen right? Let's make this a CHECK instead since this is a programming error not a user input error. - Timothy Chen On Dec. 20, 2015, 1:43 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40944/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2015, 1:43 a.m.) > > > Review request for mesos, Artem Harutyunyan, Jojy Varghese, and Timothy Chen. > > > Repository: mesos > > > Description > ------- > > Fixed protobuf parse failure when pulling a docker image. > > > Diffs > ----- > > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 7cdb15b9529eab82867b3470a016bb8ad09ff250 > src/slave/containerizer/mesos/provisioner/docker/spec.cpp > 5bbd98cb1c5f3aefd9050859d066b43360e6eb75 > src/slave/containerizer/mesos/provisioner/docker/v2.proto > fdf159d003f8e5718de0f4d8bf9a2b1374cc11a2 > src/tests/containerizer/provisioner_docker_tests.cpp > 7c1197ed03df8b5d77d26307560535f9ff5bf350 > > Diff: https://reviews.apache.org/r/40944/diff/ > > > Testing > ------- > > make check(ubuntu14.04 + clang3.6) > > > Thanks, > > Gilbert Song > >
