----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41600/#review111743 -----------------------------------------------------------
Patch looks great! Reviews applied: [41600] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Dec. 23, 2015, 6:43 a.m., Jian Qiu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41600/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 6:43 a.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-4161 > https://issues.apache.org/jira/browse/MESOS-4161 > > > Repository: mesos > > > Description > ------- > > To speed up SlaveTest.CommandExecutorWithOverride, we need to explicitly kill > the executor process and advance reap interval. > > > Diffs > ----- > > src/tests/slave_tests.cpp 90d56b987c60b99d9ca3e4ffef9cb71815bfc9b7 > > Diff: https://reviews.apache.org/r/41600/diff/ > > > Testing > ------- > > make check -j4 GTEST_FILTER=SlaveTest.CommandExecutorWithOverride takes 415ms > > [==========] Running 1 test from 1 test case. > [----------] Global test environment set-up. > [----------] 1 test from SlaveTest > [ RUN ] SlaveTest.CommandExecutorWithOverride > [ OK ] SlaveTest.CommandExecutorWithOverride (405 ms) > [----------] 1 test from SlaveTest (405 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (415 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Jian Qiu > >