> On 十二月 28, 2015, 11:15 a.m., Alexander Rukletsov wrote:
> > src/tests/slave_tests.cpp, line 435
> > <https://reviews.apache.org/r/41600/diff/1/?file=1175197#file1175197line435>
> >
> >     Mind explaining why do you think explicitly killing the executor is the 
> > right solution here? I would even propose to do it in MESOS-4161 directly 
> > for posterity.
> >     
> >     To clarify some approaches here for posterity (I will be glad to 
> > continue the conversation in the JIRA ticket once you post your explanation 
> > there). There are two separate techniques used in this review request: 
> > explicit process kill and `Clock::advance()`. Though the latter may indeed 
> > slightly speed up the test, it's not longer necessary since 
> > `process::reap()` has been accelerated (see MESOS-1199). I would let @Jian 
> > Qiu comment on the former approach.

Let's add a comment instead of explicitly killing the executor


- Jian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41600/#review111967
-----------------------------------------------------------


On 十二月 30, 2015, 2:02 a.m., Jian Qiu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41600/
> -----------------------------------------------------------
> 
> (Updated 十二月 30, 2015, 2:02 a.m.)
> 
> 
> Review request for mesos and Alexander Rukletsov.
> 
> 
> Bugs: MESOS-4161
>     https://issues.apache.org/jira/browse/MESOS-4161
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Since the reason for the test case being slow is MESOS-4111, we will add 
> comment in the test case, and remove it when MESOS-4111 is fixed.
> 
> 
> Diffs
> -----
> 
>   src/tests/slave_tests.cpp 68d75176ce7cccafdf870fff48ac6a11089311ef 
> 
> Diff: https://reviews.apache.org/r/41600/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jian Qiu
> 
>

Reply via email to