----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111749 -----------------------------------------------------------
src/master/allocator/mesos/hierarchical.cpp (line 1051) <https://reviews.apache.org/r/41597/#comment172012> So if this is not an active role, then we will not update its weight in `quotaRoleSorter`, and its weight in `quotaRoleSorter` will always be 1.0 even it becomes active later? This seems not correct. src/master/allocator/mesos/hierarchical.cpp (line 1057) <https://reviews.apache.org/r/41597/#comment172011> Do we support updating weight for an inactive role? If yes, I think this `CHECK` will fail. So I think, here we should update weight in `roleSorter` only if `roleSorter` contains the `role`. src/master/allocator/mesos/hierarchical.cpp (line 1060) <https://reviews.apache.org/r/41597/#comment171997> Should we use `quotas.contains(role)` instead? - Qian Zhang On Dec. 23, 2015, 1:46 p.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41597/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 1:46 p.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-3943 > https://issues.apache.org/jira/browse/MESOS-3943 > > > Repository: mesos > > > Description > ------- > > Add the interface in allocator to support updating weight > at runtime, and the allocator is invoked to allocate the > resources based on the updated weights later. > > > Diffs > ----- > > include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 > src/master/allocator/mesos/allocator.hpp > 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 > src/master/allocator/mesos/hierarchical.hpp > 86ea5a402ed67f8f22f11d5730147cd907d66a08 > src/master/allocator/mesos/hierarchical.cpp > 775182515dcb52bd873ecdf98c827320251a59c8 > src/master/allocator/sorter/drf/sorter.hpp > 050896e8b12cd4097ccd137d5284d6b39b0f06ab > src/master/allocator/sorter/drf/sorter.cpp > 3a442f121f3a1505513877a5c78458a4b8d0a824 > src/master/allocator/sorter/sorter.hpp > 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 > src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef > > Diff: https://reviews.apache.org/r/41597/diff/ > > > Testing > ------- > > Make & Make check successfully! > > Test case: https://reviews.apache.org/r/41672/ > > > Thanks, > > Yongqiao Wang > >
