> On Dec. 23, 2015, 8:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1057 > > <https://reviews.apache.org/r/41597/diff/2/?file=1175189#file1175189line1057> > > > > Do we support updating weight for an inactive role? If yes, I think > > this `CHECK` will fail. So I think, here we should update weight in > > `roleSorter` only if `roleSorter` contains the `role`.
Before this check, it has been ensured that the specified role contains in activeRoles, so this check will always successful. > On Dec. 23, 2015, 8:22 a.m., Qian Zhang wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1060 > > <https://reviews.apache.org/r/41597/diff/2/?file=1175189#file1175189line1060> > > > > Should we use `quotas.contains(role)` instead? Our target is to update quotaRoleSorter, so use quotaRoleSorter for checking is more clearer. - Yongqiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41597/#review111749 ----------------------------------------------------------- On Dec. 23, 2015, 9:05 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41597/ > ----------------------------------------------------------- > > (Updated Dec. 23, 2015, 9:05 a.m.) > > > Review request for mesos, Adam B, Neil Conway, and Qian Zhang. > > > Bugs: MESOS-3943 > https://issues.apache.org/jira/browse/MESOS-3943 > > > Repository: mesos > > > Description > ------- > > Add the interface in allocator to support updating weight > at runtime, and the allocator is invoked to allocate the > resources based on the updated weights later. > > > Diffs > ----- > > include/mesos/master/allocator.hpp f7ada68d7111486d264284990996413bb33333d6 > src/master/allocator/mesos/allocator.hpp > 50ef3b20f34bc6d87cbeccabcebec9a5031a6554 > src/master/allocator/mesos/hierarchical.hpp > 86ea5a402ed67f8f22f11d5730147cd907d66a08 > src/master/allocator/mesos/hierarchical.cpp > 775182515dcb52bd873ecdf98c827320251a59c8 > src/master/allocator/sorter/drf/sorter.hpp > 050896e8b12cd4097ccd137d5284d6b39b0f06ab > src/master/allocator/sorter/drf/sorter.cpp > 3a442f121f3a1505513877a5c78458a4b8d0a824 > src/master/allocator/sorter/sorter.hpp > 7be6b44a762fd62c2cd7f28b4dc4865a4587ed26 > src/tests/allocator.hpp 9bdfaecf1a148f113ad52956b50ed7cabe0902ef > > Diff: https://reviews.apache.org/r/41597/diff/ > > > Testing > ------- > > Make & Make check successfully! > > Test case: https://reviews.apache.org/r/41672/ > > > Thanks, > > Yongqiao Wang > >
