> On Dec. 24, 2015, 10:47 a.m., Adam B wrote: > > include/mesos/authorizer/authorizer.hpp, line 133 > > <https://reviews.apache.org/r/41444/diff/4/?file=1174504#file1174504line133> > > > > where did `framework_principal` come from? YOu only talk about "the > > framework principal" prior to this. Don't introduce a new special term > > unnecessarily.
It references the `framework_principals` field in `ACL::ShutdownFramework`. But I agree that we should avoid it for clarity. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review111845 ----------------------------------------------------------- On Dec. 22, 2015, 1:53 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2015, 1:53 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
