----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41444/#review112523 -----------------------------------------------------------
Ship it! Looks good enough to me. I'll fix these little things and commit this now. include/mesos/authorizer/authorizer.hpp (lines 63 - 64) <https://reviews.apache.org/r/41444/#comment173005> We can remove the "Please check..." sentence, since it repeats what's already in the class comment. include/mesos/authorizer/authorizer.hpp (line 72) <https://reviews.apache.org/r/41444/#comment173006> s/funcion/function/ include/mesos/authorizer/authorizer.hpp (lines 112 - 113) <https://reviews.apache.org/r/41444/#comment173009> "to verify the given principal can shutdown a framework originally registered by a (potentially different) framework principal." include/mesos/authorizer/authorizer.hpp (lines 128 - 129) <https://reviews.apache.org/r/41444/#comment173011> s/reserve the types of resources contained in the request/reserve the resources/ - Adam B On Dec. 24, 2015, 7:32 a.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41444/ > ----------------------------------------------------------- > > (Updated Dec. 24, 2015, 7:32 a.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Greg Mann, Jan Schlicht, > and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Extract a repetitive part of the function comments into a class comment. > Added backticks, quotes when necessary, formatted comments to avoid > jaggedness. > > > Diffs > ----- > > include/mesos/authorizer/authorizer.hpp > 19f6e1a2d025bf6ff07f515b10d41e8a48d7d0b4 > src/master/main.cpp e00f878770f3e0bddae5a137b50a00822d154e2c > > Diff: https://reviews.apache.org/r/41444/diff/ > > > Testing > ------- > > None: not a functional change. > > > Thanks, > > Alexander Rukletsov > >
