> On Dec. 27, 2015, 2:38 a.m., Jojy Varghese wrote:
> > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp, line 79
> > <https://reviews.apache.org/r/41731/diff/1/?file=1176470#file1176470line79>
> >
> >     You might have to validate the flag for its format and maybe valid path.

Actually we assume it's file:// at this point, I can even add a CHECK() here.
We will know about valid path right when we do a look up in that folder.


- Timothy


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/#review111916
-----------------------------------------------------------


On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41731/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed docker puller flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f71b572a32443a6715acb4d3541aec60e0437b30 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> dd17acf6a6e5c306029198dbb2a7e2d059f87f75 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41731/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to