-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41731/#review112336
-----------------------------------------------------------



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 72)
<https://reviews.apache.org/r/41731/#comment172808>

    Do you still need flags here?
    
    We typically try to be more explict and only pass in necessary parameters. 
All the flags validation should be done at the '::create()' method.



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (line 73)
<https://reviews.apache.org/r/41731/#comment172813>

    s/imagesDir/archivesDir/



src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp (lines 79 - 
82)
<https://reviews.apache.org/r/41731/#comment172811>

    Can you introduce a LocalPuller::create and put this logic there?



src/slave/containerizer/mesos/provisioner/docker/puller.cpp (line 53)
<https://reviews.apache.org/r/41731/#comment172816>

    No need for this temp variable?



src/slave/flags.hpp (line 55)
<https://reviews.apache.org/r/41731/#comment172798>

    Hum, this flag is confusing to me. Sounds like the  docker images (e.g., 
busybox,ubuntu...) used by Mesos.
    
    Can we keep the name 'docker_registry'?



src/slave/flags.cpp (lines 134 - 135)
<https://reviews.apache.org/r/41731/#comment172804>

    Can you briefly explain what will be there if a file location is specified:
    ```
    or a local path (i.e., file://xxx) in which Docker image archives (result 
of 'docker save') are stored.
    ```



src/tests/containerizer/provisioner_docker_tests.cpp (line 1462)
<https://reviews.apache.org/r/41731/#comment172817>

    s/imageDir/archivesDir/
    
    Can you fix all the occurances?


- Jie Yu


On Dec. 27, 2015, 12:22 a.m., Timothy Chen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41731/
> -----------------------------------------------------------
> 
> (Updated Dec. 27, 2015, 12:22 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Jie Yu, and Jojy Varghese.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Removed docker puller flag.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp 
> f71b572a32443a6715acb4d3541aec60e0437b30 
>   src/slave/containerizer/mesos/provisioner/docker/puller.cpp 
> dd17acf6a6e5c306029198dbb2a7e2d059f87f75 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 7cdb15b9529eab82867b3470a016bb8ad09ff250 
>   src/slave/flags.hpp 1250786d1bdc8b312a1912a37ac8aac373dd5ec9 
>   src/slave/flags.cpp c4343ab7ff7b7b4d2c335119d41319b0779d2806 
>   src/tests/containerizer/provisioner_docker_tests.cpp 
> bb142f5ea99e8ea9b20a896f95ae37aa1d8d3f98 
> 
> Diff: https://reviews.apache.org/r/41731/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>

Reply via email to