-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41283/#review112114
-----------------------------------------------------------



src/executor/executor.cpp (line 54)
<https://reviews.apache.org/r/41283/#comment172435>

    Do you really need the entire slave namespace or something narrower like 
``` mesos::internal::slave::validation::executor```



src/executor/executor.cpp (line 118)
<https://reviews.apache.org/r/41283/#comment172432>

    const?



src/executor/executor.cpp (line 183)
<https://reviews.apache.org/r/41283/#comment172440>

    Why not UPID ```upid(value.get());```



src/executor/executor.cpp (line 221)
<https://reviews.apache.org/r/41283/#comment172433>

    "else" case?



src/executor/executor.cpp (line 232)
<https://reviews.apache.org/r/41283/#comment172434>

    "else" case?



src/executor/executor.cpp (line 255)
<https://reviews.apache.org/r/41283/#comment172436>

    See comment about namespace scope.



src/executor/executor.cpp (line 256)
<https://reviews.apache.org/r/41283/#comment172437>

    why blank line?



src/executor/executor.cpp (line 264)
<https://reviews.apache.org/r/41283/#comment172438>

    Why declare response far from its use? Its preferred that the declarations 
be closer to their use.



src/executor/executor.cpp (line 266)
<https://reviews.apache.org/r/41283/#comment172439>

    Why not use universal initialization ({....})?


- Jojy Varghese


On Dec. 29, 2015, 12:11 a.m., Anand Mazumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41283/
> -----------------------------------------------------------
> 
> (Updated Dec. 29, 2015, 12:11 a.m.)
> 
> 
> Review request for mesos, Ben Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-3550
>     https://issues.apache.org/jira/browse/MESOS-3550
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This change introduces the implementation for the executor library. 
> 
> This uses the new HTTP Connection interface to ensure calls are properly 
> pipelined.
> 
> `connected` -> Callback invoked when a TCP connection is established with the 
> agent.
> `disconnected` -> When the TCP connection is interrupted possibly due to an 
> agent restart.
> `received` -> When the executor receives events from the agent upon 
> subscribing.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e 
>   src/executor/executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41283/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Reply via email to