> On Dec. 29, 2015, 2:46 a.m., Jojy Varghese wrote: > > src/executor/executor.cpp, line 221 > > <https://reviews.apache.org/r/41283/diff/2/?file=1177077#file1177077line221> > > > > "else" case? > > Anand Mazumdar wrote: > Nothing needs to be done for the `else` case. These env variables > **might** be set by the agent when framework checkpointing is enabled. For > more info see how the old executor library checks it: > https://github.com/apache/mesos/blob/master/src/exec/exec.cpp#L690 > > Jojy Varghese wrote: > hrm in the else case, what would be the value of recoveryTimeout? > > Anand Mazumdar wrote: > The value would be the default value of `Duration` i.e. `0ns` i.e. you > would like your executor to not retry and shut down as soon as you detect a > disconnection with the agent (as is the case for frameworks that do not have > checkpointing enabled). Makes sense ? > > Jojy Varghese wrote: > So checkpoint with no MESOS_RECOVERY_TIMEOUT / > MESOS_RETRY_MAX_BACKOFF_FACTOR is same as no checkpoint?
I think if framework intends to be “checkpointed”, then we shud have a warning when “recoverytimeout” is not present because the only thing checkpoint env variable provides is recoveryTimeout and maxBackOff. - Jojy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41283/#review112114 ----------------------------------------------------------- On Dec. 29, 2015, 3:11 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41283/ > ----------------------------------------------------------- > > (Updated Dec. 29, 2015, 3:11 a.m.) > > > Review request for mesos, Ben Mahler and Vinod Kone. > > > Bugs: MESOS-3550 > https://issues.apache.org/jira/browse/MESOS-3550 > > > Repository: mesos > > > Description > ------- > > This change introduces the implementation for the executor library. > > This uses the new HTTP Connection interface to ensure calls are properly > pipelined. > > `connected` -> Callback invoked when a TCP connection is established with the > agent. > `disconnected` -> When the TCP connection is interrupted possibly due to an > agent restart. > `received` -> When the executor receives events from the agent upon > subscribing. > > > Diffs > ----- > > src/Makefile.am 9762f8567e32d70b8df2d694a1fef5c692fc730e > src/executor/executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/41283/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >