> On Dec. 30, 2015, 8:46 p.m., Klaus Ma wrote: > > src/common/resources.cpp, line 854 > > <https://reviews.apache.org/r/41772/diff/1/?file=1177401#file1177401line854> > > > > I'd suggest to only return `stateless.reserved` resources; allocator > > need role info to exclude current framework's reserved resources. > > > > Not sure which name is better, maybe `allocationSlackable` > > (ALLOCATION_SLACK-able) which means the resources that can be > > ALLOCATION_SLACK to other framework.
Instead of calling `stateless().flattenReserved().flattenSlack()`, I'd like to call `allcationSlackable().flatten().flattenSlack()`. - Klaus ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/#review112310 ----------------------------------------------------------- On Jan. 2, 2016, 9:16 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41772/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2016, 9:16 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Repository: mesos > > > Description > ------- > > Added two new helper functions to flatten resources. > 1) Flatten reserved resources. > 2) Flatten allocation slack revocable resources. > > > Diffs > ----- > > include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d > include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa > src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 > > Diff: https://reviews.apache.org/r/41772/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
