----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41772/#review113153 -----------------------------------------------------------
include/mesos/resources.hpp (lines 267 - 275) <https://reviews.apache.org/r/41772/#comment173656> I'd recommend killing these. See issues below. src/common/resources.cpp (lines 880 - 891) <https://reviews.apache.org/r/41772/#comment173652> Does this give you more value than something like this? ``` resources.filter(isReserved).flatten() ``` src/common/resources.cpp (lines 894 - 904) <https://reviews.apache.org/r/41772/#comment173654> This seems more appropriate as an optional parameter for `Resources::flatten`, just like `Option<Resource::ReservationInfo>`. - Joseph Wu On Jan. 3, 2016, 1:42 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41772/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2016, 1:42 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, and Klaus Ma. > > > Bugs: MESOS-4267 > https://issues.apache.org/jira/browse/MESOS-4267 > > > Repository: mesos > > > Description > ------- > > Added two new helper functions to flatten resources. > 1) Flatten reserved resources. > 2) Flatten allocation slack revocable resources. > > > Diffs > ----- > > include/mesos/resources.hpp 9c8bfb0e7e1e40ca99b4cc75079e5b950630243d > include/mesos/v1/resources.hpp db87c992e2ec466cb1d4d17775bf6423a2fb15aa > src/common/resources.cpp b9d31aef8babee212374e352c57fadbff02167f3 > src/tests/resources_tests.cpp e4a3435adc14f3b6b278b32348a6991543d5a320 > src/v1/resources.cpp 0c0eee6b3b7ae3254d7dc7b06187855c9b873764 > > Diff: https://reviews.apache.org/r/41772/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
