> On Jan. 3, 2016, 10:48 a.m., Joerg Schad wrote: > > This pretty much duplicates https://reviews.apache.org/r/39466/ (except > > also has a test case). Even though the long term approach should be to > > replace all the individual http method call with a general one (accepting a > > Request object), we should decide which of these reviews we want to > > commit/focus on right now. > > Joerg Schad wrote: > Ah saw just above comment about this being tempory, would be good to add > that in the description . Thanks :-).
Thank Joerg for your comments. I think for the short term we should commit https://reviews.apache.org/r/39466/ firstly, because current there is an urgent test case needs it. After that, we can consider to replace all the individual http method call with a general one. - Yongqiao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review112445 ----------------------------------------------------------- On Jan. 4, 2016, 1:50 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2016, 1:50 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil > Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Add put method for http PUT request. > > Note: This is a tempory, and only created for #41681 dependency. The same > patch https://reviews.apache.org/r/39466/ has be posted, I have talked with > Joerg owner of that RR to speed up that ticket. After that RR commit, then we > can discard this. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > f0666f0fa48c4f3a98332d12066561a02a715236 > 3rdparty/libprocess/src/http.cpp e937df6875c8024ea9c178833b9faceede990969 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > ------- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >