----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41789/#review113694 -----------------------------------------------------------
Why not add an overload for `put()`? It could call into the more generic `request()`, like you want to do with post/get 3rdparty/libprocess/include/process/http.hpp (lines 802 - 804) <https://reviews.apache.org/r/41789/#comment174487> This would all fit on one line, so please unwrap. 3rdparty/libprocess/include/process/http.hpp <https://reviews.apache.org/r/41789/#comment174488> Please add this line back. 3rdparty/libprocess/src/http.cpp (lines 1218 - 1221) <https://reviews.apache.org/r/41789/#comment174489> Will you add `query` as a parameter only once you've moved `get()` over to this? Does anybody even set the `contentType` yet? 3rdparty/libprocess/src/http.cpp (line 1223) <https://reviews.apache.org/r/41789/#comment174491> What if SSL is enabled/required? How would you use https? 3rdparty/libprocess/src/http.cpp (line 1250) <https://reviews.apache.org/r/41789/#comment174490> Why not continue to call it 'request'? `http::httpRequest()` seems redundant. - Adam B On Jan. 9, 2016, 3:37 a.m., Yongqiao Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41789/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2016, 3:37 a.m.) > > > Review request for mesos, Adam B, Joerg Schad, Joris Van Remoortere, Neil > Conway, and Qian Zhang. > > > Bugs: MESOS-4200 > https://issues.apache.org/jira/browse/MESOS-4200 > > > Repository: mesos > > > Description > ------- > > Expose the internal::http::request function in the header and not add an > additional method/overload for put function. > > (TODO): Clean the other instances of post/get to use the http::request method. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/http.hpp > ed708fe4b0006782a19f9c61603f152e32a02e8e > 3rdparty/libprocess/src/http.cpp 06231d96c6c99cada0cd46d6ef1e3f64039215c2 > > Diff: https://reviews.apache.org/r/41789/diff/ > > > Testing > ------- > > Make & Make check successfully. > > > Thanks, > > Yongqiao Wang > >
