> On Jan. 4, 2016, 9:14 p.m., Mesos ReviewBot wrote:
> > Bad patch!
> > 
> > Reviews applied: [40975]
> > 
> > Failed command: ./support/apply-review.sh -n -r 40975
> > 
> > Error:
> >  2016-01-04 21:14:40 URL:https://reviews.apache.org/r/40975/diff/raw/ 
> > [1164/1164] -> "40975.patch" [1]
> > No files to lint
> > 
> > Error: Commit message summary (the first line) must end in a period.
> 
> James Peach wrote:
>     Well AFAICT "Document that libprocess ignores SIGPIPE." *does* end in a 
> period.
> 
> Vinod Kone wrote:
>     the summary line above doesn't have a period. am i missing something?

``apply-review.sh`` is adding tht somehow. The commit that I fed to 
``post-reviews.sh`` doesn't have it.

```
mesos.git jpeach$ git show
commit efa6b867e7c421de3102bd00674ef2aa37610de8
Author: James Peach <jpe...@apache.org>
Date:   Fri Dec 4 09:31:44 2015 -0800

    Document that libprocess ignores SIGPIPE.

    Review: https://reviews.apache.org/r/40975

diff --git a/3rdparty/libprocess/README.md b/3rdparty/libprocess/README.md
index 6a47f67..3bd0c7c 100644
--- a/3rdparty/libprocess/README.md
+++ b/3rdparty/libprocess/README.md
@@ -30,6 +30,7 @@ At a higher level, functional composition of processes is 
facilitated using [fut
 * [HTTP](#http)
 * [Testing](#testing)
 * [Miscellaneous Primitives](#miscellaneous-primitives)
+* [Signal Handling](#signal-handling)

 ---

@@ -653,3 +654,13 @@ int main()
 ### `async`

 Async defines a function template for asynchronously executing function 
closures. It provides their results as [futures](#futures-and-promises).
+
+## Signal handling
+
+In general, libprocess does not depend on signals or interfere with
+the host processes signal handling policy. The exception is that
+it always ignores `SIGPIPE` globally, so the host process must not
+depend on `SIGPIPE` being delivered when performing I/O on disconnected
+pipes or sockets.  libprocess APIs that perform I/O will always
+return an appropriately wrapped EPIPE error code (usually a stout
+`ErrnoError` object) instead of raising `SIGPIPE`.
```


- James


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40975/#review112647
-----------------------------------------------------------


On Jan. 4, 2016, 4:31 p.m., James Peach wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40975/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 4:31 p.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Document that libprocess ignores SIGPIPE.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/README.md 6a47f6772bb7a74af368ed970af0f1c154a070e3 
> 
> Diff: https://reviews.apache.org/r/40975/diff/
> 
> 
> Testing
> -------
> 
> None.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Reply via email to