> On Jan. 4, 2016, 10:26 p.m., Vinod Kone wrote:
> > Can you attach the screenshot of the webui with these changes?
> 
> Diogo Gomes wrote:
>     Sure:
>     
>     index.html 
>     
> ![index.html](https://www.evernote.com/l/AEuvTZAB75dJHZCXhYl-o6kg_-QGxGC3Fu8B/image.png)
>     
>     offers.html 
>     
> ![offers.html](https://www.evernote.com/l/AEvG7nUTwwVDoohVNfohbXih6iJlQgooz6IB/image.png)
> 
> Vinod Kone wrote:
>     How about justing calling it "Offers" in the black band? That way it is 
> consistent with "Frameowrks" and "Slaves" which do not have any qualifiers. 
> Also, it leaves the door open for the "Offers" page to have more than 
> "Outstanding Offers" in the future (e.g., accepted offers, declined offers 
> etc).

Totally agree, I'll change the commit and update here


- Diogo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41891/#review112710
-----------------------------------------------------------


On Jan. 4, 2016, 10:23 p.m., Diogo Gomes wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41891/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 10:23 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3817
>     https://issues.apache.org/jira/browse/MESOS-3817
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Renaming offers to outstanding offers.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/index.html 25caf530628ad3ac7f23ab5f014000aac8583da1 
>   src/webui/master/static/offers.html 
> cc199352fcf2074dcd0e8d24bb49651b38c41d86 
> 
> Diff: https://reviews.apache.org/r/41891/diff/
> 
> 
> Testing
> -------
> 
> Can be tested running Mesos Master web-ui front page and offers page (now 
> named as Outstanding Offers). Only html changed.
> 
> 
> Thanks,
> 
> Diogo Gomes
> 
>

Reply via email to