-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112840
-----------------------------------------------------------
After looking at all authz test I think we can make one `RequestAuthorization`
test of 2 exisiting tests and 2 you propose. This will allow us to save on
`SetUp()`, `TearDown()` and avoid copy-paste code. To separate cases inside the
test you can scope them in {} blocks.
src/tests/master_quota_tests.cpp (line 1259)
<https://reviews.apache.org/r/41550/#comment173327>
This test almost entirely includes `AuthorizedQuotaSetRequest`. See below
my suggestion regarding merging these.
src/tests/master_quota_tests.cpp (line 1322)
<https://reviews.apache.org/r/41550/#comment173325>
This test includes `AuthorizedQuotaSetRequestWithoutPrincipal` entirely.
How about you simply add ACLs for remove quota and requestDelete invokation to
that test and rename it accordingly? You may want to wrap requests in scopes
for clarity.
src/tests/master_quota_tests.cpp (line 1380)
<https://reviews.apache.org/r/41550/#comment173329>
Again, I think this one can be merged with `AuthorizedQuotaRemoveRequest`
(you can use scopes for clarity). After a second thought I think we can go even
further and merge `UnauthorizedQuotaSetRequest` into those as well. What do you
think?
- Alexander Rukletsov
On Jan. 5, 2016, 11:17 a.m., Jan Schlicht wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 11:17 a.m.)
>
>
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
>
>
> Bugs: MESOS-4083
> https://issues.apache.org/jira/browse/MESOS-4083
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Quota Authorization: Added tests for quota removal authorization.
>
>
> Diffs
> -----
>
> src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350
> src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33
>
> Diff: https://reviews.apache.org/r/41550/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jan Schlicht
>
>
