-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41550/#review112889
-----------------------------------------------------------



src/tests/master_quota_tests.cpp (lines 1118 - 1124)
<https://reviews.apache.org/r/41550/#comment173367>

    Let's insert blank lines between ACL blocks for readability.



src/tests/master_quota_tests.cpp (lines 1201 - 1207)
<https://reviews.apache.org/r/41550/#comment173368>

    Same here, let's add blank lines.



src/tests/master_quota_tests.cpp (lines 1308 - 1318)
<https://reviews.apache.org/r/41550/#comment173376>

    You don't really need an agent here, you can set the force flag and remove 
this boilerplate code. Check the cleanup here: 
https://reviews.apache.org/r/41939



src/tests/master_quota_tests.cpp (lines 1320 - 1329)
<https://reviews.apache.org/r/41550/#comment173378>

    You can wrap this code into a {} block for readability.



src/tests/master_quota_tests.cpp (lines 1332 - 1339)
<https://reviews.apache.org/r/41550/#comment173379>

    Same here, a good candidate for a block.


- Alexander Rukletsov


On Jan. 5, 2016, 3:13 p.m., Jan Schlicht wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41550/
> -----------------------------------------------------------
> 
> (Updated Jan. 5, 2016, 3:13 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Till Toenshoff.
> 
> 
> Bugs: MESOS-4083
>     https://issues.apache.org/jira/browse/MESOS-4083
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Quota Authorization: Added tests for quota removal authorization.
> 
> 
> Diffs
> -----
> 
>   src/tests/authorization_tests.cpp 1d11a02032c142455debd9c78d4ee4cc6297a350 
>   src/tests/master_quota_tests.cpp 2f1bc3ae6a370e466f7cea9b597f51d7eccb1b33 
> 
> Diff: https://reviews.apache.org/r/41550/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Reply via email to