> On Jan. 7, 2016, 2:38 p.m., Joerg Schad wrote: > > src/master/flags.cpp, line 210 > > <https://reviews.apache.org/r/42025/diff/2/?file=1186277#file1186277line210> > > > > Please add to configuration.md
Thanks! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113255 ----------------------------------------------------------- On Jan. 7, 2016, 2:38 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42025/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 2:38 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Bernd Mathiske, and Jan > Schlicht. > > > Bugs: MESOS-3024 > https://issues.apache.org/jira/browse/MESOS-3024 > > > Repository: mesos > > > Description > ------- > > Adds new `authenticate_http` flag to the master. > Also updates some tests that were using the credentials > for de/activating HTTP authentication. > > > Diffs > ----- > > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d > src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 > > Diff: https://reviews.apache.org/r/42025/diff/ > > > Testing > ------- > > make check > > functional testing by playing with the framework shutdown endpoint (teardown). > > --- > > ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http > -> fails with "No credentials provided for the default 'basic' HTTP > authenticator." > > ---- > > ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http > --credentials=file://some_valid_file > ./src/test-framework --master=127.0.0.1:5050 > > curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v > -> fails with "HTTP/1.1 401 Unauthorized" > > curl --user invalid:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> fails with "HTTP/1.1 401 Unauthorized" > > curl --user valid:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > ---- > > ./bin/mesos-master.sh --work_dir=/tmp --credentials=file://some_valid_file > ./src/test-framework --master=127.0.0.1:5050 > > curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > curl --user some:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > > Thanks, > > Till Toenshoff > >