> On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/tests/master_quota_tests.cpp, line 1103 > > <https://reviews.apache.org/r/42025/diff/7/?file=1186454#file1186454line1103> > > > > Does it matter that credentials != None()? Should you maybe clear out > > credentials as well?
It should not matter but seems somewhat cleaner to me, agreed. > On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/tests/master_quota_tests.cpp, line 1359 > > <https://reviews.apache.org/r/42025/diff/7/?file=1186454#file1186454line1359> > > > > Ditto Ditto. > On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/master/master.cpp, line 544 > > <https://reviews.apache.org/r/42025/diff/7/?file=1186453#file1186453line544> > > > > This no longer needs to be an `else if`, right? It can just be an > > `else` now. Doh, thanks! > On Jan. 7, 2016, 10:04 p.m., Adam B wrote: > > src/master/master.cpp, lines 530-534 > > <https://reviews.apache.org/r/42025/diff/7/?file=1186453#file1186453line530> > > > > We don't usually put punctuation at the end of log/exit lines. Dang, thanks! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42025/#review113336 ----------------------------------------------------------- On Jan. 7, 2016, 8:29 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42025/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2016, 8:29 p.m.) > > > Review request for mesos, Adam B, Alexander Rojas, Bernd Mathiske, Ben > Mahler, Jan Schlicht, and Vinod Kone. > > > Bugs: MESOS-3024 > https://issues.apache.org/jira/browse/MESOS-3024 > > > Repository: mesos > > > Description > ------- > > Adds new `authenticate_http` flag to the master. > Also updates some tests that were using the credentials > for de/activating HTTP authentication. > > > Diffs > ----- > > docs/configuration.md fb6f6784e5d11850ba0bafaeafa3213a1038e6b4 > src/master/flags.hpp 9af6c68eef6bcf39d5776809fab6c66dc95da6b2 > src/master/flags.cpp f864419a6276356c97a0a4fe29e5cfce6c4660c4 > src/master/master.cpp 40ce3e17fca88da689128bcf5d35fdddc396c011 > src/tests/master_quota_tests.cpp bc8a117982b994279e0df7639b21abaeb308b76d > src/tests/mesos.cpp 3867ed2fcb197f98f0a19ca37ed81392db27e8a0 > > Diff: https://reviews.apache.org/r/42025/diff/ > > > Testing > ------- > > make check > > functional testing by playing with the framework shutdown endpoint (teardown). > > --- > > ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http > -> fails with "No credentials provided for the default 'basic' HTTP > authenticator." > > ---- > > ./bin/mesos-master.sh --work_dir=/tmp --authenticate_http > --credentials=file://some_valid_file > ./src/test-framework --master=127.0.0.1:5050 > > curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v > -> fails with "HTTP/1.1 401 Unauthorized" > > curl --user invalid:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> fails with "HTTP/1.1 401 Unauthorized" > > curl --user valid:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > ---- > > ./bin/mesos-master.sh --work_dir=/tmp --credentials=file://some_valid_file > ./src/test-framework --master=127.0.0.1:5050 > > curl --data "frameworkId=valid_framework_id" 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > curl --user some:credentials --data "frameworkId=valid_framework_id" > 127.0.0.1:5050/teardown -v > -> succeeds with "HTTP/1.1 200 OK" > > > Thanks, > > Till Toenshoff > >
