> On Jan. 3, 2016, 2:43 a.m., Klaus Ma wrote:
> > I think it's too early to update total allocation slack here; my suggestion 
> > to handle dynamic reservation:
> > 
> > 1. Did not reduce total allocation slack in 
> > updateAllocation/updateAvailable; but if no allocated ALLOCATIONS_SLACK, 
> > it's fine to shrink it.
> > 2. In agent, if new checkpointed resources is smaller, evict executors if 
> > necessary.
> > 3. In allocator, did not send evicting unreserved resources 
> > (allocationSlack - stateless.reserved)
> > 4. In Allocator::recoverResources, if total allocation slack is smaller 
> > than stateless.reserved, shrink total allocation slack.

I agree except for 2).

If a lender framework *unreserves* resources, the tenant framework effectively 
becomes the sole user of said resources.  The allocator could treat these 
revocable resources as normal resources.  There's no reason to evict in this 
case.


- Joseph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41791/#review112443
-----------------------------------------------------------


On Jan. 3, 2016, 1:22 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41791/
> -----------------------------------------------------------
> 
> (Updated Jan. 3, 2016, 1:22 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-4145
>     https://issues.apache.org/jira/browse/MESOS-4145
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Updated allocation slack when dynamic reservation was updated.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 7f900c4e024485704d79e57ae22407557598fe6c 
>   src/tests/hierarchical_allocator_tests.cpp 
> e044f832c2c16e53e663c6ced5452649bb0dcb59 
> 
> Diff: https://reviews.apache.org/r/41791/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to