> On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 659 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line659> > > > > s/int */int* / > > Project style guide: > > http://mesos.apache.org/documentation/latest/c++-style-guide/ > > > > s/mibDev/mibDevice/?
Done and Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 658 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line658> > > > > s/xswdSz/xswdSize/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 657 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line657> > > > > Perhaps comment here that FreeBSD supports multiple swap devices and > > this sums across them all. Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 652 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line652> > > > > s/mibSz/mibSize/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 649 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line649> > > > > s/usedBlks/usedBlocks/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 648 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line648> > > > > s/totalBlks/totalBlocks/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 633 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line633> > > > > Any particular reason why the OSX code above uses sysconf but it's okay > > to use getpagesize() on FreeBSD? Are they equivalent...? On FreeBSD, sysconf() calls getpagesize() for _SC_PAGESIZE (and the man page states they are equivelent). The OS X man page doesn't say if the two are equivelent, and the Linux page says to use sysconf for portablility. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 627 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line627> > > > > Please use complete words unless it's something defined externally. > > s/physMem/physicalMemory/ Done. > On Jan. 7, 2016, 8:05 p.m., Ian Downes wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp, line 626 > > <https://reviews.apache.org/r/41726/diff/2/?file=1176463#file1176463line626> > > > > Not yours, but this is getting clumsy. Can you please add a TODO to > > refactor this into separate, platform specfic files. I thought about that while writing this, but didn't want to be presumptuous. I'll split things up in another change. Done. - David ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41726/#review113310 ----------------------------------------------------------- On Jan. 8, 2016, 12:52 a.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41726/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2016, 12:52 a.m.) > > > Review request for mesos and Ian Downes. > > > Bugs: MESOS-4251 > https://issues.apache.org/jira/browse/MESOS-4251 > > > Repository: mesos > > > Description > ------- > > Implement os::memory() for FreeBSD. > > > Diffs > ----- > > 3rdparty/libprocess/3rdparty/stout/include/stout/posix/os.hpp > 4cf693fb7e8c6bb3ad1920ebe90d61f0adb5dc99 > > Diff: https://reviews.apache.org/r/41726/diff/ > > > Testing > ------- > > gmake check > > > Thanks, > > David Forsythe > >
