> On 一月 7, 2016, 11:38 p.m., Joseph Wu wrote:
> > src/master/validation.cpp, line 487
> > <https://reviews.apache.org/r/41848/diff/2/?file=1186200#file1186200line487>
> >
> >     This is probably not necessary.
> >     
> >     Before you'd see:
> >     "Task (and its executor, if exists) uses both revocable and 
> > non-revocable cpus".
> >     
> >     With your change, it becomes:
> >     "Task (and its executor, if exists) uses both revocable and 
> > non-revocable cpus(*){USAGE_SLACK}:1".
> >     
> >     I prefer the first one.

I want to handle the case if there are both usage slack and allocation slack, 
such as:

"Task (and its executor, if exists) uses both revocable and non-revocable 
cpus(*){USAGE_SLACK}:1;cpus(*){ALLOCATION_SLACK}:2".

But the above message may not accurate, as the error can also promoted if no 
non-revocable resources but only allocation slack and usage slack. Seems the 
error message needs to be udated.


- Guangya


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41848/#review113354
-----------------------------------------------------------


On 一月 7, 2016, 11:26 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41848/
> -----------------------------------------------------------
> 
> (Updated 一月 7, 2016, 11:26 a.m.)
> 
> 
> Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van 
> Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu.
> 
> 
> Bugs: MESOS-3931
>     https://issues.apache.org/jira/browse/MESOS-3931
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Do not enable task and its executor run on different resources. They
> must run on same kind of resources, either non-revocable resources, usage
> slack resources or allocation slack resources.
> 
> 
> Diffs
> -----
> 
>   src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 
>   src/tests/master_validation_tests.cpp 
> fbf8fadbc04a7cbc60ee6091e0224339389b400f 
> 
> Diff: https://reviews.apache.org/r/41848/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to