> On Jan. 8, 2016, 1:29 p.m., Timothy Chen wrote:
> > src/tests/container_logger_tests.cpp, line 222
> > <https://reviews.apache.org/r/41962/diff/1/?file=1183514#file1183514line222>
> >
> > Do we need to check that the correct container id is passed?
It wouldn't hurt. I'll add it to both tests.
The second argument here is a the string `sandboxDirectory`, which is expected
to be:
```
slave::paths::getExecutorRunPath(
flags.work_dir,
slaveState.id,
frameworkState.id,
executorId,
containerId)
```
- Joseph
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41962/#review113538
-----------------------------------------------------------
On Jan. 5, 2016, 6:19 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41962/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2016, 6:19 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Gilbert Song, Artem Harutyunyan,
> Jie Yu, and Timothy Chen.
>
>
> Bugs: MESOS-4150
> https://issues.apache.org/jira/browse/MESOS-4150
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Adds two heavily-mocked tests for the Mesos containerizer and Docker
> containerizer. Each checks that `ContainerLogger::recover` is called during
> `Containerizer::recover`.
>
>
> Diffs
> -----
>
> src/tests/container_logger_tests.cpp
> c6b2e597517c74a55649287dc5ae5a3115f9a640
> src/tests/mesos.hpp a4811b0d8dee33ff2ca4968f532ce64b7ea95249
> src/tests/mesos.cpp f4b0f82449c4b6a2b4b7b7f14518714485d5a13a
>
> Diff: https://reviews.apache.org/r/41962/diff/
>
>
> Testing
> -------
>
> make (OSX & Centos7)
>
> Tests are run in the next review.
>
>
> Thanks,
>
> Joseph Wu
>
>
