> On 十二月 30, 2015, 12:42 p.m., Klaus Ma wrote: > > src/master/allocator/mesos/hierarchical.cpp, line 1334 > > <https://reviews.apache.org/r/40632/diff/8/?file=1178313#file1178313line1334> > > > > In this check, it seems allocator send offer when both !allocation & > > allocation are enough. > > Joseph Wu wrote: > Looks like quota might have stepped on the toes of oversubscription. > I'll double-check with Joris/AlexR. > > Guangya Liu wrote: > Not quite clear about the problem, can you elaborate? Joseph? > > Klaus Ma wrote: > @Joseph, the Quota only handle `unreserved.nonRevocable` resources; so > `USAGE_SLACK` are not included in Quota. > > Joseph Wu wrote: > Right. The quota code may prevent the allocation of USAGE_SLACK. When > quota is met, USAGE_SLACK will not be allocated (if the agent has > non-revocable available resources). > > With your change, ALLOCATION_SLACK is allocated, even if quota is met. > This isn't your problem originally, but we'd want to address both types of > slack (or leave a TODO and address neither of them).
As non revocable resources are not counted for quota, so I think that we should allocate them in DRF stage without considering quota. The current patch is only handling allocation slack, I will add some TODO comments here to clarify that usage slack also needs to be considered here. - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40632/#review112309 ----------------------------------------------------------- On 一月 8, 2016, 6:55 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40632/ > ----------------------------------------------------------- > > (Updated 一月 8, 2016, 6:55 a.m.) > > > Review request for mesos, Ben Mahler, Artem Harutyunyan, Joris Van > Remoortere, Joseph Wu, Klaus Ma, and Jian Qiu. > > > Bugs: MESOS-4145 > https://issues.apache.org/jira/browse/MESOS-4145 > > > Repository: mesos > > > Description > ------- > > Enabled oversubscribed resources for reservations in allocator. > > There are three patches handling the allocator part: > 1) This patch handles send offer, add slave and quota integration test. > 2) https://reviews.apache.org/r/41847/ Handles the case of update slave. > 3) https://reviews.apache.org/r/41791/ Handles the case of dynamic > reservations. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > df8bccaf2b8cfc0cb5ca18d4867371ae7a84c12f > src/tests/hierarchical_allocator_tests.cpp > e044f832c2c16e53e663c6ced5452649bb0dcb59 > > Diff: https://reviews.apache.org/r/40632/diff/ > > > Testing > ------- > > make > make check > > > Thanks, > > Guangya Liu > >
