-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42149/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 5:16 a.m.)


Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and Timothy 
Chen.


Changes
-------

Less changes, creating the latch by need.


Bugs: MESOS-3235
    https://issues.apache.org/jira/browse/MESOS-3235


Repository: mesos


Description
-------

Also inlined the function that awaits fetch contention.

This mutex was prone to causing races at task startup by firmly
blocking an internal libprocess thread. The latch avoids this.

Failing to launch a task due to such a race did not get flagged
by directly related test failures, because the AWAIT catching this
situation was ineffective, having been placed inside a call from the
test. Only the subsequent wait for task completion triggered a test
failure then. By then it was obscured what exactly had happened.


Diffs (updated)
-----

  src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 

Diff: https://reviews.apache.org/r/42149/diff/


Testing
-------

make check
bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure 
--gtest_filter="*HttpCachedConcurrent*"


Thanks,

Bernd Mathiske

Reply via email to