----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42149/#review114043 -----------------------------------------------------------
Patch looks great! Reviews applied: [42149] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 12, 2016, 2:55 p.m., Bernd Mathiske wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42149/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2016, 2:55 p.m.) > > > Review request for mesos, Adam B, Benjamin Hindman, Till Toenshoff, and > Timothy Chen. > > > Bugs: MESOS-3235 > https://issues.apache.org/jira/browse/MESOS-3235 > > > Repository: mesos > > > Description > ------- > > Also inlined the function that awaits fetch contention. > > This mutex was prone to causing races at task startup by firmly > blocking an internal libprocess thread. The latch avoids this. > > Failing to launch a task due to such a race did not get flagged > by directly related test failures, because the AWAIT catching this > situation was ineffective, having been placed inside a call from the > test. Only the subsequent wait for task completion triggered a test > failure then. By then it was obscured what exactly had happened. > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp 1fb1e213d3c35479789688d1a3a49a3c6058b198 > > Diff: https://reviews.apache.org/r/42149/diff/ > > > Testing > ------- > > make check > bin/mesos-tests.sh --gtest_repeat=1000 --gtest_break_on_failure > --gtest_filter="*HttpCachedConcurrent*" > > > Thanks, > > Bernd Mathiske > >
