----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42164/ -----------------------------------------------------------
(Updated Jan. 12, 2016, 4:43 p.m.) Review request for mesos, Alexander Rojas, Michael Park, and Neil Conway. Changes ------- Addressed comment, fixed segfault in the absence of a principal. Bugs: MESOS-3940 https://issues.apache.org/jira/browse/MESOS-3940 Repository: mesos Description ------- Allowed (un)reserve operations without a principal. Diffs (updated) ----- src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 src/tests/master_validation_tests.cpp fbf8fadbc04a7cbc60ee6091e0224339389b400f src/tests/reservation_endpoints_tests.cpp b8edd6fafedd4c2221a8d19c1ebc71254071a8c7 Diff: https://reviews.apache.org/r/42164/diff/ Testing ------- Two master validation tests were removed which tested to make sure that reserve and unreserve operations would not succeed without a principal. `make check` was used to test on both OSX and Ubuntu 14.04 Thanks, Greg Mann