----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42165/#review114167 -----------------------------------------------------------
Patch looks great! Reviews applied: [42164, 42165] Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh - Mesos ReviewBot On Jan. 11, 2016, 10:40 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42165/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2016, 10:40 p.m.) > > > Review request for mesos, Alexander Rojas, Michael Park, and Neil Conway. > > > Bugs: MESOS-3940 > https://issues.apache.org/jira/browse/MESOS-3940 > > > Repository: mesos > > > Description > ------- > > Removed `hasPrincipal` parameter from unreserve validation. > > > Diffs > ----- > > src/master/http.cpp bcafc7aff89659a68352f3876ce6042f8b34bd5d > src/master/master.cpp 2d9b7f9540574aa3ef9e5af3b2b8922dffeebac8 > src/master/validation.hpp 380b40279faf180a6f401a5e28280b601dbc648c > src/master/validation.cpp 6a43bce5b7df6a9d939245c4726d060fa19eb305 > src/tests/master_validation_tests.cpp > fbf8fadbc04a7cbc60ee6091e0224339389b400f > > Diff: https://reviews.apache.org/r/42165/diff/ > > > Testing > ------- > > Several instances of the relevant validation function were altered in the > master validation tests. > > `make check` was used to test on both OSX and Ubuntu 14.04 > > > Thanks, > > Greg Mann > >
